Use CBMC version 5.95.1 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming CBMC version 6 release includes changes that may affect existing proofs. This PR will make sure that coreMQTT-Agent PRs are not negatively impacted by this release. After releasing CBMC version 6 we will issue a follow-up PR that will return coreMQTT-Agent to using CBMC's latest release, and will include any changes to proofs that may be necessary to support the new version.
shubnil
approved these changes
Jun 6, 2024
Given the risk that changes in CBMC's back-end may adversely affect the performance of individual proofs (even when we are hoping it would generally just improve performance) I'd like to push back against this: on this one occasion of a major version bump I'd like to exercise extra care and only bump one repository at a time. Once we are happy with v6 across all FreeRTOS-related projects I'd agree that the right thing is to just leave it to the global config. |
tony-josi-aws
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The upcoming CBMC version 6 release includes changes that may affect existing proofs. This PR will make sure that coreMQTT-Agent PRs are not negatively impacted by this release. After releasing CBMC version 6 we will issue a follow-up PR that will return coreMQTT-Agent to using CBMC's latest release, and will include any changes to proofs that may be necessary to support the new version.
Test Steps
Tested in CI (no changes in behaviour at this point)
Checklist:
Related Issue
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.